chia7712 commented on PR #15621: URL: https://github.com/apache/kafka/pull/15621#issuecomment-2026641230
> (1) revert all offsetForMaxTimestamp to shallowOffsetMaxTimestamp (2) change/revert the implementation to set shallowOffsetMaxTimestamp accordingly. Do we need to revert all of them? the paths we had fixed works well now. 1) It seems to me adding comments for both "recover" and "follower" cases can remind readers that this `offsetOfMaxTimestampMs` is shallow. 2) or we can only rename `offsetForMaxTimestamp` back to `shallowOffsetMaxTimestamp` but we keep the implementation. @junrao WDYT? > (3) add tests for follower appends will complete it later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
