lianetm commented on code in PR #15525:
URL: https://github.com/apache/kafka/pull/15525#discussion_r1548593248
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1141,21 +1146,29 @@ private Map<TopicPartition, Long>
beginningOrEndOffset(Collection<TopicPartition
if (partitions.isEmpty()) {
return Collections.emptyMap();
}
+
Map<TopicPartition, Long> timestampToSearch = partitions
- .stream()
- .collect(Collectors.toMap(Function.identity(), tp ->
timestamp));
+ .stream()
+ .collect(Collectors.toMap(Function.identity(), tp ->
timestamp));
Timer timer = time.timer(timeout);
ListOffsetsEvent listOffsetsEvent = new ListOffsetsEvent(
- timestampToSearch,
- false,
- timer);
- Map<TopicPartition, OffsetAndTimestamp> offsetAndTimestampMap =
applicationEventHandler.addAndGet(
- listOffsetsEvent,
- timer);
- return offsetAndTimestampMap
- .entrySet()
- .stream()
- .collect(Collectors.toMap(Map.Entry::getKey, e ->
e.getValue().offset()));
+ timestampToSearch,
+ timer,
+ false);
+
+ Map<TopicPartition, OffsetAndTimestampInternal>
offsetAndTimestampMap;
+ if (timeout.isZero()) {
+ applicationEventHandler.add(listOffsetsEvent);
Review Comment:
Thanks for the explanation! Totally ok to tackle it with that separate Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
