OmniaGM commented on code in PR #15655: URL: https://github.com/apache/kafka/pull/15655#discussion_r1551787559
########## clients/src/main/java/org/apache/kafka/common/network/SslTransportLayer.java: ########## @@ -199,6 +199,14 @@ public void close() throws IOException { } catch (IOException ie) { log.debug("Failed to send SSL Close message", ie); } finally { + try { + sslEngine.closeInbound(); + } catch (SSLException e) { + // This is a debug log because an exception may be raised here frequently due to peers which do not + // follow the TLS spec and fail to send a close_notify alert. Even if they do, we currently don't read + // data from the socket after close() is invoked. Review Comment: ```suggestion // This log is for debugging purposes as an exception might occur frequently // at this point due to peers not following the TLS specs and failing to send a close_notify alert. // Even if they do, currently, we do not read data from the socket after invoking close(). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org