dajac commented on PR #15652: URL: https://github.com/apache/kafka/pull/15652#issuecomment-2037428994
> Also, it seems the following classes are useless. Yeah, I noticed those classes too. I am actually not sure what we kept them. It may be for backward compatibility. I need to dig a little more on it. It is anyway not related to this patch so we can treat it separately. > Not sure whether this will hurt the users who are using this tool to observe the assignments. Maybe we can parse subscription and assignment according to official kafka consumer, and convert the parse exception (https://issues.apache.org/jira/browse/KAFKA-15603) to log message instead of throwing exception. WDYT? I don't think users rely on this tool to read the assignments. At least, I never did. The annoying part is that we cannot reuse the auto-generated structures if we want to preserve this. We need to introduce a new structure which is basically the autogenerated one + new fields for holding the deserialised arrays. I am not fan of this because they will for sure diverge in the future. I will think a little more about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
