chia7712 commented on PR #15678:
URL: https://github.com/apache/kafka/pull/15678#issuecomment-2047578617

   > If the condition doesn't meet within the maxWaitMs, the waitForCondition 
would throw the assertion failure. Do we need another timeout to handle that?
   
   My origin thought was to use Junit 5 timeout, but we can't observe the 
method from the error stack if the error is produced by junit timeout. So +1 to 
current approach


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to