chia7712 commented on code in PR #15684:
URL: https://github.com/apache/kafka/pull/15684#discussion_r1559774590


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -16,14 +16,132 @@
  */
 package org.apache.kafka.coordinator.group;
 
+import org.apache.kafka.common.record.CompressionType;
+import org.apache.kafka.common.utils.Utils;
 import org.apache.kafka.coordinator.group.assignor.PartitionAssignor;
+import org.apache.kafka.coordinator.group.assignor.RangeAssignor;
+import org.apache.kafka.coordinator.group.assignor.UniformAssignor;
 
+import java.util.Arrays;
+import java.util.Collections;
 import java.util.List;
 
 /**
  * The group coordinator configurations.
  */
 public class GroupCoordinatorConfig {
+    /** ********* Group coordinator configuration ***********/
+    public final static String GROUP_MIN_SESSION_TIMEOUT_MS_CONFIG = 
"group.min.session.timeout.ms";
+    public final static String GROUP_MIN_SESSION_TIMEOUT_MS_DOC = "The minimum 
allowed session timeout for registered consumers. Shorter timeouts result in 
quicker failure detection at the cost of more frequent consumer heartbeating, 
which can overwhelm broker resources.";
+    public static final int GROUP_MIN_SESSION_TIMEOUT_MS_DEFAULT = 6000;
+
+    public final static String GROUP_MAX_SESSION_TIMEOUT_MS_CONFIG = 
"group.max.session.timeout.ms";
+    public final static String GROUP_MAX_SESSION_TIMEOUT_MS_DOC = "The maximum 
allowed session timeout for registered consumers. Longer timeouts give 
consumers more time to process messages in between heartbeats at the cost of a 
longer time to detect failures.";
+    public static final int GROUP_MAX_SESSION_TIMEOUT_MS_DEFAULT = 1800000;
+
+    public final static String GROUP_INITIAL_REBALANCE_DELAY_MS_CONFIG = 
"group.initial.rebalance.delay.ms";
+    public final static String GROUP_INITIAL_REBALANCE_DELAY_MS_DOC = "The 
amount of time the group coordinator will wait for more consumers to join a new 
group before performing the first rebalance. A longer delay means potentially 
fewer rebalances, but increases the time until processing begins.";
+    public static final int GROUP_INITIAL_REBALANCE_DELAY_MS_DEFAULT = 3000;
+
+    public final static String GROUP_MAX_SIZE_CONFIG = "group.max.size";
+    public final static String GROUP_MAX_SIZE_DOC = "The maximum number of 
consumers that a single consumer group can accommodate.";
+    public static final int GROUP_MAX_SIZE_DEFAULT = Integer.MAX_VALUE;
+
+    /** New group coordinator configs */
+    public final static String NEW_GROUP_COORDINATOR_ENABLE_CONFIG = 
"group.coordinator.new.enable";
+    public final static String NEW_GROUP_COORDINATOR_ENABLE_DOC = "Enable the 
new group coordinator.";
+    public static final boolean NEW_GROUP_COORDINATOR_ENABLE_DEFAULT = false;
+
+    public final static String GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG = 
"group.coordinator.rebalance.protocols";
+    public final static String GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DOC = 
"The list of enabled rebalance protocols. Supported protocols: " + 
Utils.join(Group.GroupType.values(), ",") + ". " +
+            "The " + Group.GroupType.CONSUMER + " rebalance protocol is in 
early access and therefore must not be used in production.";
+    public static final List<String> 
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DEFAULT = 
Collections.singletonList(Group.GroupType.CLASSIC.toString());
+
+    public final static String GROUP_COORDINATOR_NUM_THREADS_CONFIG = 
"group.coordinator.threads";
+    public final static String GROUP_COORDINATOR_NUM_THREADS_DOC = "The number 
of threads used by the group coordinator.";
+    public static final int GROUP_COORDINATOR_NUM_THREADS_DEFAULT = 1;
+
+    /** Consumer group configs */
+    public final static String CONSUMER_GROUP_SESSION_TIMEOUT_MS_CONFIG = 
"group.consumer.session.timeout.ms";
+    public final static String CONSUMER_GROUP_SESSION_TIMEOUT_MS_DOC = "The 
timeout to detect client failures when using the consumer group protocol.";
+    public static final int CONSUMER_GROUP_SESSION_TIMEOUT_MS_DEFAULT = 45000;
+
+    public final static String CONSUMER_GROUP_MIN_SESSION_TIMEOUT_MS_CONFIG = 
"group.consumer.min.session.timeout.ms";
+    public final static String CONSUMER_GROUP_MIN_SESSION_TIMEOUT_MS_DOC = 
"The minimum allowed session timeout for registered consumers.";
+    public static final int CONSUMER_GROUP_MIN_SESSION_TIMEOUT_MS_DEFAULT = 
45000;
+
+    public final static String CONSUMER_GROUP_MAX_SESSION_TIMEOUT_MS_CONFIG = 
"group.consumer.max.session.timeout.ms";
+    public final static String CONSUMER_GROUP_MAX_SESSION_TIMEOUT_MS_DOC = 
"The maximum allowed session timeout for registered consumers.";
+    public static final int CONSUMER_GROUP_MAX_SESSION_TIMEOUT_MS_DEFAULT = 
60000;
+
+    public final static String CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG = 
"group.consumer.heartbeat.interval.ms";
+    public final static String CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DOC = "The 
heartbeat interval given to the members of a consumer group.";
+    public static final int CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DEFAULT = 
5000;
+
+    public final static String CONSUMER_GROUP_MIN_HEARTBEAT_INTERVAL_MS_CONFIG 
= "group.consumer.min.heartbeat.interval.ms";
+    public final static String CONSUMER_GROUP_MIN_HEARTBEAT_INTERVAL_MS_DOC = 
"The minimum heartbeat interval for registered consumers.";
+    public static final int CONSUMER_GROUP_MIN_HEARTBEAT_INTERVAL_MS_DEFAULT = 
5000;
+
+    public final static String CONSUMER_GROUP_MAX_HEARTBEAT_INTERVAL_MS_CONFIG 
= "group.consumer.max.heartbeat.interval.ms";
+    public final static String CONSUMER_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DOC = 
"The maximum heartbeat interval for registered consumers.";
+    public static final int CONSUMER_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DEFAULT = 
15000;
+
+    public final static String CONSUMER_GROUP_MAX_SIZE_CONFIG = 
"group.consumer.max.size";
+    public final static String CONSUMER_GROUP_MAX_SIZE_DOC = "The maximum 
number of consumers that a single consumer group can accommodate.";

Review Comment:
   this is unrelated to this PR, but this doc is equal to `GROUP_MAX_SIZE_DOC` 
(classic version). It would be nice to make some difference for them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to