C0urante commented on code in PR #15728:
URL: https://github.com/apache/kafka/pull/15728#discussion_r1569197938
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java:
##########
@@ -169,6 +170,7 @@ static Map<String, Object> sourceConsumerConfig(Map<String,
?> props) {
result.putAll(Utils.entriesWithPrefix(props, CONSUMER_CLIENT_PREFIX));
result.putAll(Utils.entriesWithPrefix(props, SOURCE_PREFIX +
CONSUMER_CLIENT_PREFIX));
result.put(ENABLE_AUTO_COMMIT_CONFIG, "false");
+ result.put(ALLOW_AUTO_CREATE_TOPICS_CONFIG, "false");
Review Comment:
While this may be more ideal for many use cases, it's a potentially-breaking
change that I don't believe we can make without waiting for a major release
(right now, that'd be 4.0.0), and an accepted KIP. If you're unfamiliar with
the KIP process, you can read more about it here:
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals#KafkaImprovementProposals-Purpose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
