kamalcph commented on code in PR #15634:
URL: https://github.com/apache/kafka/pull/15634#discussion_r1569356239
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1223,6 +1223,12 @@ class UnifiedLog(@volatile var logStartOffset: Long,
s"but we only have log segments starting from offset:
$logStartOffset.")
}
+ private def checkLocalLogStartOffset(offset: Long): Unit = {
Review Comment:
Agree on this. The `checkLocalLogStartOffset` is used only in the
`convertToOffsetMetadataOrThrow` method which reads from local-disk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
