emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1571063662
##########
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##########
@@ -1281,14 +1281,14 @@ private Meter createMeter(Metrics metrics, String
groupName, Map<String, String
/**
* This method generates `time-total` metrics but has a couple of
deficiencies: no `-ns` suffix and no dash between basename
- * and `time-toal` suffix.
+ * and `time-total` suffix.
* @deprecated use {{@link #createIOThreadRatioMeter(Metrics, String,
Map, String, String)}} for new metrics instead
*/
@Deprecated
private Meter createIOThreadRatioMeterLegacy(Metrics metrics, String
groupName, Map<String, String> metricTags,
String baseName, String action) {
MetricName rateMetricName = metrics.metricName(baseName +
"-ratio", groupName,
- String.format("*Deprecated* The fraction of time the I/O
thread spent %s", action), metricTags);
+ String.format("The fraction of time the I/O thread spent
%s", action), metricTags);
Review Comment:
Added in method javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
