lucasbru commented on code in PR #15723:
URL: https://github.com/apache/kafka/pull/15723#discussion_r1571335784
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java:
##########
@@ -98,12 +93,11 @@ public boolean canSendRequest(final long currentTimeMs) {
* is a request in-flight.
*/
public boolean requestInFlight() {
- return this.lastSentMs > -1 && this.lastReceivedMs < this.lastSentMs;
+ return requestInFlight;
Review Comment:
`inflightRequested` seems to change the meaning. Who requested an inflight?
In my head it's clearly the noun "request", but if you are bothered, may I
suggest "isRequestInFlight"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
