lucasbru commented on code in PR #15753:
URL: https://github.com/apache/kafka/pull/15753#discussion_r1572534438


##########
tests/kafkatest/tests/client/consumer_rolling_upgrade_test.py:
##########
@@ -56,12 +56,7 @@ def _verify_roundrobin_assignment(self, consumer):
         metadata_quorum=[quorum.isolated_kraft],
         use_new_coordinator=[True, False]
     )
-    @matrix(
-        metadata_quorum=quorum.all_kraft,
-        use_new_coordinator=[True],
-        group_protocol=consumer_group.all_group_protocols

Review Comment:
   Hey @lianetm. My understanding was that this does test with the new 
coordinator also after the update, and the default is group_protocol=classic, 
so this should be fine right? Unless you want to add `combined_kraft`, but not 
sure if that's an interesting case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to