rreddy-22 commented on code in PR #15717: URL: https://github.com/apache/kafka/pull/15717#discussion_r1572729047
########## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/TargetAssignmentBuilderBenchmark.java: ########## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.jmh.assignor; + +import org.apache.kafka.common.Uuid; +import org.apache.kafka.coordinator.group.assignor.AssignmentMemberSpec; +import org.apache.kafka.coordinator.group.assignor.AssignmentSpec; +import org.apache.kafka.coordinator.group.assignor.GroupAssignment; +import org.apache.kafka.coordinator.group.assignor.MemberAssignment; +import org.apache.kafka.coordinator.group.assignor.PartitionAssignor; +import org.apache.kafka.coordinator.group.assignor.UniformAssignor; +import org.apache.kafka.coordinator.group.consumer.Assignment; +import org.apache.kafka.coordinator.group.consumer.ConsumerGroupMember; +import org.apache.kafka.coordinator.group.consumer.SubscribedTopicMetadata; +import org.apache.kafka.coordinator.group.consumer.TargetAssignmentBuilder; +import org.apache.kafka.coordinator.group.consumer.TopicMetadata; +import org.apache.kafka.coordinator.group.consumer.VersionedMetadata; +import org.openjdk.jmh.annotations.Benchmark; +import org.openjdk.jmh.annotations.BenchmarkMode; +import org.openjdk.jmh.annotations.Fork; +import org.openjdk.jmh.annotations.Level; +import org.openjdk.jmh.annotations.Measurement; +import org.openjdk.jmh.annotations.Mode; +import org.openjdk.jmh.annotations.OutputTimeUnit; +import org.openjdk.jmh.annotations.Param; +import org.openjdk.jmh.annotations.Scope; +import org.openjdk.jmh.annotations.Setup; +import org.openjdk.jmh.annotations.State; +import org.openjdk.jmh.annotations.Threads; +import org.openjdk.jmh.annotations.Warmup; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; +import java.util.concurrent.TimeUnit; + +@State(Scope.Benchmark) +@Fork(value = 1) +@Warmup(iterations = 5) +@Measurement(iterations = 5) +@BenchmarkMode(Mode.AverageTime) +@OutputTimeUnit(TimeUnit.MILLISECONDS) +public class TargetAssignmentBuilderBenchmark { + + @Param({"100", "500", "1000", "5000", "10000"}) + private int memberCount; + + @Param({"5", "10", "50"}) + private int partitionsToMemberRatio; + + @Param({"10", "100", "1000"}) + private int topicCount; + + private static final String GROUP_ID = "benchmark-group"; + + private static final int GROUP_EPOCH = 0; + + private PartitionAssignor partitionAssignor; + + private Map<String, TopicMetadata> subscriptionMetadata = Collections.emptyMap(); + + private TargetAssignmentBuilder targetAssignmentBuilder; + + private AssignmentSpec assignmentSpec; + + private final List<String> allTopicNames = new ArrayList<>(topicCount); + + private final List<Uuid> allTopicIds = new ArrayList<>(topicCount); + + @Setup(Level.Trial) + public void setup() { + // For this benchmark we will use the Uniform Assignor + // and a group that has a homogeneous subscription model. + partitionAssignor = new UniformAssignor(); + + subscriptionMetadata = generateMockSubscriptionMetadata(); + Map<String, ConsumerGroupMember> members = generateMockMembers(); + Map<String, Assignment> existingTargetAssignment = generateMockInitialTargetAssignment(); + + // Add a new member to trigger a rebalance. + Set<String> subscribedTopics = new HashSet<>(subscriptionMetadata.keySet()); + + ConsumerGroupMember newMember = new ConsumerGroupMember.Builder("new-member") + .setSubscribedTopicNames(new ArrayList<>(subscribedTopics)) + .build(); + + targetAssignmentBuilder = new TargetAssignmentBuilder(GROUP_ID, GROUP_EPOCH, partitionAssignor) + .withMembers(members) + .withSubscriptionMetadata(subscriptionMetadata) + .withTargetAssignment(existingTargetAssignment) + .addOrUpdateMember(newMember.memberId(), newMember); + } + + private Map<String, ConsumerGroupMember> generateMockMembers() { + Map<String, ConsumerGroupMember> members = new HashMap<>(); + + for (int i = 0; i < memberCount - 1; i++) { + Set<String> subscribedTopics; + subscribedTopics = new HashSet<>(allTopicNames); Review Comment: ah yes, I missed changing that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
