chia7712 commented on PR #15616: URL: https://github.com/apache/kafka/pull/15616#issuecomment-2067966296
> thanks for the great suggestion. I took a look LogSegment#deleteIfExists and LogSegment#deleteTypeIfExists. If we want to handle fallback deletion in LocalLog, we may need to return true/false in that two functions. However, LogSegment#deleteIfExists uses Utils.tryAll to handle 4 try/catch blocks. If we want to return true/false, we need to refactor Utils.tryAll as well. Finally, LogSegment#deleteIfExists is not only used by LocalLog.deleteSegmentFiles, but also LocalLog.splitOverflowedSegment. We need to handle LocalLog.splitOverflowedSegment path, too. I think we can use another Jira to track the change. Thanks. agree. Let's ship it first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
