chia7712 commented on code in PR #15772:
URL: https://github.com/apache/kafka/pull/15772#discussion_r1573848774
##########
server/src/main/java/org/apache/kafka/server/config/Defaults.java:
##########
@@ -46,6 +42,10 @@ public class Defaults {
public static final int METADATA_MAX_IDLE_INTERVAL_MS = 500;
public static final int METADATA_MAX_RETENTION_BYTES = 100 * 1024 * 1024;
public static final boolean DELETE_TOPIC_ENABLE = true;
+ public static final int REQUEST_TIMEOUT_MS = 30000;
+ public static final long CONNECTION_SETUP_TIMEOUT_MS =
CommonClientConfigs.DEFAULT_SOCKET_CONNECTION_SETUP_TIMEOUT_MS;
+ public static final long CONNECTION_SETUP_TIMEOUT_MAX_MS =
CommonClientConfigs.DEFAULT_SOCKET_CONNECTION_SETUP_TIMEOUT_MAX_MS;
Review Comment:
ditto
##########
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##########
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.network;
+
+import org.apache.kafka.common.network.ListenerName;
+import org.apache.kafka.common.security.auth.SecurityProtocol;
+import org.apache.kafka.server.config.ReplicationConfigs;
+import java.util.Arrays;
+import java.util.stream.Collectors;
+
+public class SocketServerConfigs {
+ public static final String LISTENER_SECURITY_PROTOCOL_MAP_CONFIG =
"listener.security.protocol.map";
+ public static final String LISTENER_SECURITY_PROTOCOL_MAP_DEFAULT =
Arrays.stream(SecurityProtocol.values())
+ .collect(Collectors.toMap(sp ->
ListenerName.forSecurityProtocol(sp), sp -> sp))
Review Comment:
`.collect(Collectors.toMap(ListenerName::forSecurityProtocol, sp -> sp))`
##########
server/src/main/java/org/apache/kafka/server/config/Defaults.java:
##########
@@ -46,6 +42,10 @@ public class Defaults {
public static final int METADATA_MAX_IDLE_INTERVAL_MS = 500;
public static final int METADATA_MAX_RETENTION_BYTES = 100 * 1024 * 1024;
public static final boolean DELETE_TOPIC_ENABLE = true;
+ public static final int REQUEST_TIMEOUT_MS = 30000;
+ public static final long CONNECTION_SETUP_TIMEOUT_MS =
CommonClientConfigs.DEFAULT_SOCKET_CONNECTION_SETUP_TIMEOUT_MS;
Review Comment:
Do we need `CONNECTION_SETUP_TIMEOUT_MS` as it is used by
`KafkaConfig.scala` only.
##########
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##########
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.network;
+
+import org.apache.kafka.common.network.ListenerName;
+import org.apache.kafka.common.security.auth.SecurityProtocol;
+import org.apache.kafka.server.config.ReplicationConfigs;
+import java.util.Arrays;
+import java.util.stream.Collectors;
+
+public class SocketServerConfigs {
Review Comment:
Should we call it `ServerSocketConfigs` so as to align it with
`ServerLogConfigs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
