chia7712 commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1573850549
########## core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala: ########## @@ -17,48 +17,78 @@ package kafka.server -import kafka.test.{ClusterConfig, ClusterInstance} +import kafka.test.ClusterInstance import org.apache.kafka.common.message.ApiVersionsRequestData import org.apache.kafka.common.protocol.{ApiKeys, Errors} import org.apache.kafka.common.requests.ApiVersionsRequest -import kafka.test.annotation.{ClusterConfigProperty, ClusterTest, ClusterTestDefaults, Type} +import kafka.test.annotation.{ClusterConfigProperty, ClusterTest, ClusterTestDefaults, ClusterTests, Type} import kafka.test.junit.ClusterTestExtensions import org.apache.kafka.server.common.MetadataVersion import org.junit.jupiter.api.Assertions._ -import org.junit.jupiter.api.BeforeEach import org.junit.jupiter.api.extension.ExtendWith @ExtendWith(value = Array(classOf[ClusterTestExtensions])) -@ClusterTestDefaults(clusterType = Type.ALL, brokers = 1) +@ClusterTestDefaults(brokers = 1) class ApiVersionsRequestTest(cluster: ClusterInstance) extends AbstractApiVersionsRequestTest(cluster) { - @BeforeEach - def setup(config: ClusterConfig): Unit = { - super.brokerPropertyOverrides(config.serverProperties()) - } - - @ClusterTest(metadataVersion = MetadataVersion.IBP_3_8_IV0, serverProperties = Array( - new ClusterConfigProperty(key = "unstable.api.versions.enable", value = "false"), - new ClusterConfigProperty(key = "unstable.metadata.versions.enable", value = "true"), + @ClusterTests(Array( + new ClusterTest(clusterType = Type.ZK, metadataVersion = MetadataVersion.IBP_3_8_IV0, serverProperties = Array( Review Comment: > Currently we can't add ClusterTemplate in ClusterTests. Should we do that is this PR ? Could you file a Jira for that? Also, we can leave a TODO here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org