ilyazr commented on code in PR #15701:
URL: https://github.com/apache/kafka/pull/15701#discussion_r1575051333
##########
metadata/src/test/java/org/apache/kafka/controller/errors/EventHandlerExceptionInfoTest.java:
##########
@@ -72,6 +73,11 @@ public class EventHandlerExceptionInfoTest {
new TimeoutException(),
() -> OptionalInt.of(1));
+ private static final EventHandlerExceptionInfo KAFKA_EXCEPTION =
+ EventHandlerExceptionInfo.fromInternal(
+ new KafkaException("Custom kafka exception message"),
+ () -> OptionalInt.of(1));
+
Review Comment:
Initially I thought it would be better to keep all
`EventHandlerExceptionInfo` declarations at the same place. But as you
mentioned, you would be even better to have it on a method level as it is used
only once. Moved `TIMEOUT` to the method too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
