brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576432963
##########
core/src/test/java/kafka/testkit/BrokerNode.java:
##########
@@ -121,16 +146,16 @@ public BrokerNode build(
private final boolean combined;
private final Map<String, String> propertyOverrides;
- BrokerNode(
+ private BrokerNode(
Uuid incarnationId,
MetaPropertiesEnsemble initialMetaPropertiesEnsemble,
boolean combined,
Map<String, String> propertyOverrides
) {
- this.incarnationId = incarnationId;
- this.initialMetaPropertiesEnsemble = initialMetaPropertiesEnsemble;
Review Comment:
I make `logDataDirectories()` return Set<String> instead List<String> to get
rid of the redundant arraylist wrapping.
##########
core/src/test/java/kafka/testkit/BrokerNode.java:
##########
@@ -121,16 +146,16 @@ public BrokerNode build(
private final boolean combined;
private final Map<String, String> propertyOverrides;
- BrokerNode(
+ private BrokerNode(
Uuid incarnationId,
MetaPropertiesEnsemble initialMetaPropertiesEnsemble,
boolean combined,
Map<String, String> propertyOverrides
) {
- this.incarnationId = incarnationId;
- this.initialMetaPropertiesEnsemble = initialMetaPropertiesEnsemble;
Review Comment:
I make `logDataDirectories()` return `Set<String>` instead `List<String>` to
get rid of the redundant arraylist wrapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
