OmniaGM commented on PR #15775: URL: https://github.com/apache/kafka/pull/15775#issuecomment-2074952186
> > Note: We have already RaftConfig but it seems to contain limited amount of configs that only configure controller raft and shouldn't include configs shared by both broker/controller in KRAFT mode or only for broker in KRAFT mode. > > What about moving `KRaftConfig` to raft module? and we can moving all configs from `RaftConfig` to `KRaftConfig`. With those changes, all raft-related configs are in `KRaftConfig`. `RaftConfig` can be a POJO. We can move it to raft module but 1. I am concerned that this will create other circle dependencies later when we move the raft package and KafkaRaftServer out of core 2. I don't think we should merge them with RaftConfig as RaftConfig should be separate as it is only for the quorum raft and not KRAFT mode which are a bit different in my option. Most of the configs in KRaftConfigs are used by SharedServer, KafkaRaftServer or BrokerLifeCycle. I think we either keep the pr as proposed or maybe we can have in server-common module the following 1. MetadataLogConfigs for anything with prefix `metadata` 2. KafkaRaftServerConfigs for the rest anything 3. Keep RaftServer separated but move it to server-common Personally I think the first option is easier to navigate as we know where all the config used by Kafka Raft server (maybe renaming this to `KafkaRaftServerConfigs` instead of `KRaftConfigs` would be better) are and where all the config used by Quorum Raft. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
