mumrah commented on code in PR #15754:
URL: https://github.com/apache/kafka/pull/15754#discussion_r1577998958
##########
tests/kafkatest/tests/core/zookeeper_migration_test.py:
##########
@@ -86,10 +87,35 @@ def do_migration(self, roll_controller = False,
downgrade_to_zk = False):
controller.stop_node(node)
controller.start_node(node)
+ if downgrade_to_zk:
+ self.logger.info("Shutdown brokers to avoid waiting on unclean
shutdown")
+ for node in self.kafka.nodes:
+ self.kafka.stop_node(node)
+ metadata_log_dir = KafkaService.METADATA_LOG_DIR +
"/__cluster_metadata-0"
+ for node in self.kafka.nodes:
+ assert path_exists(node, metadata_log_dir), "Should still
have a metadata log on the brokers."
+
+ self.logger.info("Shutdown KRaft quorum")
+ for node in controller.nodes:
+ controller.stop_node(node)
+
+ self.logger.info("Deleting controller ZNode")
+ self.zk.delete(path="/controller", recursive=True)
+
+ self.logger.info("Rolling brokers back to ZK mode")
+ self.kafka.downgrade_kraft_broker_to_zk(controller)
+ for node in self.kafka.nodes:
+ self.kafka.start_node(node)
+
+ # This blocks until all brokers have a full ISR
+ self.wait_until_rejoin()
Review Comment:
No, it doesn't require a full shutdown. Let me see if I can fix this here.
Good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
