chia7712 commented on code in PR #15797: URL: https://github.com/apache/kafka/pull/15797#discussion_r1578498362
########## raft/src/main/java/org/apache/kafka/raft/QuorumConfigs.java: ########## @@ -47,7 +47,7 @@ * controller should be able to transition from standby to active without reloading all of * the metadata. The standby is a "hot" standby, not a "cold" one. */ -public class RaftConfig { +public class QuorumConfigs { Review Comment: It seems to me QuorumConfig`s` implies that we should not have instance of it. However, we do instantiate it, and so could we rename it to `QuorumConfig`? Another similar case is `LogConfig`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org