TaiJuWu commented on PR #15800: URL: https://github.com/apache/kafka/pull/15800#issuecomment-2076019523
> @TaiJuWu thanks for this contribution. btw, is this check ( > > https://github.com/apache/kafka/blob/81c222e9779c3339aa139ab930a74aba2c7c8685/core/src/test/java/kafka/test/junit/ClusterTestExtensions.java#L92 > > ) unnecessary? Yes, I believe it’s unnecessary. If we give default value (code on truncated branch), the size must be greater zero, we just need to select one. Here we have two solutions, one is current version, the other is you look last time. I don’t take any position, both are great for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
