kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579884608
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1270,6 +1230,20 @@ private void close(Duration timeout, boolean
swallowException) {
if (applicationEventHandler != null)
closeQuietly(() ->
applicationEventHandler.close(Duration.ofMillis(closeTimer.remainingMs())),
"Failed shutting down network thread", firstException);
closeTimer.update();
+
+ if (backgroundEventReaper != null && backgroundEventQueue != null) {
Review Comment:
Added a brief comment. PTAL.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -128,7 +138,19 @@ void runOnce() {
// Process the events—if any—that were produced by the application
thread. It is possible that when processing
// an event generates an error. In such cases, the processor will log
an exception, but we do not want those
// errors to be propagated to the caller.
- applicationEventProcessor.process();
+ LinkedList<ApplicationEvent> events = new LinkedList<>();
+ applicationEventQueue.drainTo(events);
+
+ for (ApplicationEvent event : events) {
+ try {
+ if (event instanceof CompletableApplicationEvent)
+
applicationEventReaper.add((CompletableApplicationEvent<?>) event);
+
+ applicationEventProcessor.process(event);
+ } catch (Throwable t) {
+ log.warn("Error processing event {}", t.getMessage(), t);
+ }
+ }
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
