splett2 commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1579894472
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -66,6 +69,7 @@ public class ConfigurationControlManager {
private final TimelineHashMap<ConfigResource, TimelineHashMap<String,
String>> configData;
private final Map<String, Object> staticConfig;
private final ConfigResource currentController;
+ private final MinIsrConfigUpdatePartitionHandler
minIsrConfigUpdatePartitionHandler;
Review Comment:
maybe more of a question for someone with more code ownership of the quorum
controller code, but I wonder if it would be preferable to handle generating
the replication control manager records in the
`QuorumController.incrementalAlterConfigs`. That would also make it a bit
easier to handle `validateOnly` which we are not currently handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
