mumrah commented on code in PR #15744:
URL: https://github.com/apache/kafka/pull/15744#discussion_r1580149700
##########
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##########
@@ -620,16 +620,19 @@ class ZkMigrationIntegrationTest {
// Alter the metadata
log.info("Updating metadata with AdminClient")
admin = zkCluster.createAdminClient()
- alterTopicConfig(admin).all().get(60, TimeUnit.SECONDS)
- alterClientQuotas(admin).all().get(60, TimeUnit.SECONDS)
+ alterTopicConfig(admin)
+ alterClientQuotas(admin)
+ alterBrokerConfigs(admin)
// Verify the changes made to KRaft are seen in ZK
log.info("Verifying metadata changes with ZK")
verifyTopicConfigs(zkClient)
verifyClientQuotas(zkClient)
+ verifyBrokerConfigs(zkClient)
val nextKRaftProducerId =
sendAllocateProducerIds(zkCluster.asInstanceOf[ZkClusterInstance]).get(30,
TimeUnit.SECONDS)
assertNotEquals(nextProducerId, nextKRaftProducerId)
-
+ } catch {
+ case t: Throwable => fail("Uncaught error in test", t)
Review Comment:
Just my preference I guess. I've seen many cases where its hard to see where
a test failing due to a throw. Maybe this is better in recent versions of JUnit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
