tinaselenge commented on code in PR #15377: URL: https://github.com/apache/kafka/pull/15377#discussion_r1581029496
########## core/src/test/scala/integration/kafka/api/SslAdminIntegrationTest.scala: ########## @@ -259,4 +275,22 @@ class SslAdminIntegrationTest extends SaslSslAdminIntegrationTest { assertTrue(metrics.nonEmpty, s"Unable to find metric $name: allMetrics: ${allMetrics.keySet.map(_.getMBeanName)}") metrics.map(_.asInstanceOf[Gauge[Int]].value).sum } + + override def createAdminClient: Admin = { Review Comment: So I initially thought the `createConfig()` in BaseAdminIntegrationTest is creating different security properties by calling `TestUtils.adminClientSecurityConfigs()` than the security properties created as part of the set up in IntegrationTestHarness. However following all the properties `adminClientSecurityConfigs()` set, they are exactly the same except the `certAlias`. So basically BaseAdminIntegrationTest mostly just setting security properties twice for no good reason. This seems to upset SSL admin test, because of the mismatch in the certAlias. Removing the unnecessary call to `adminClientSecurityConfigs()` in BaseAdminIntegrationTest worked for all of the tests. Thanks for pointing this out! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org