rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1581134610
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##########
@@ -620,9 +637,10 @@ public Map<String, TopicMetadata>
computeSubscriptionMetadata(
TopicsImage topicsImage,
ClusterImage clusterImage
) {
- // Copy and update the current subscriptions.
+ // Copy and update the current subscription information.
Map<String, Integer> subscribedTopicNames = new
HashMap<>(this.subscribedTopicNames);
maybeUpdateSubscribedTopicNames(subscribedTopicNames, oldMember,
newMember);
+ maybeUpdateGroupSubscriptionType();
Review Comment:
ohhhh that makes sense, I wasn't sure what the reasoning was, okie I'll
remove it, thanks for explaining
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
