gaurav-narula commented on code in PR #15836:
URL: https://github.com/apache/kafka/pull/15836#discussion_r1586365674
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -389,9 +389,17 @@ class BrokerServer(
authorizer = config.createNewAuthorizer()
authorizer.foreach(_.configure(config.originals))
- val fetchManager = new FetchManager(Time.SYSTEM,
- new FetchSessionCache(config.maxIncrementalFetchSessionCacheSlots,
- KafkaServer.MIN_INCREMENTAL_FETCH_SESSION_EVICTION_MS))
+ // The FetchSessionCache is divided into config.numIoThreads shards,
each responsible
+ // for sessionIds falling in [Max(1, shardNum * sessionIdRange),
(shardNum + 1) * sessionIdRange)
+ val sessionIdRange = Int.MaxValue / config.numIoThreads
Review Comment:
Using `config.numIoThreads` is a heuristic and I reckon it's okay if shard
count isn't modified dynamically along with numIoThreads.
In fact, I realised my "After" benchmark was with 8 shards and not 64 as I
had a misconfiguration while running it which goes to show even some sharding
goes a long way. How about we introduce a constant for now and set it to 8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
