showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1592297330
##########
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##########
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log cleanup interval is configured to be 500 ms. We need to wait at
least that amount of time before
// segments eligible for deletion gets physically removed.
- public static final Integer STORAGE_WAIT_TIMEOUT_SEC = 5;
+ public static final Integer STORAGE_WAIT_TIMEOUT_SEC = 10;
Review Comment:
Yes, I think the test is flaky because the CI environment is quite slow, and
maybe the IO is slower than we thought. From the log I can see, at
`08:59:27,187`, we copied `00000000000000000002.log` to remote. And after 1
second of `00000000000000000002.log` copied to remote (`08:59:28,300`), it
timed out and all resources started to get closed.
I've waited 10 seconds for the log deletion to get completed, but obviously
it's not enough for CI env. I've increased to 20 seconds and see if it fixes
the issue. I think we've done what we can do to make it faster (i.e. set the
configs to speed up the tests)
```
[2024-05-04 08:59:27,187] INFO [RemoteLogManager=0
partition=DcnVRVRSQd675ZLtCIn21A:topicB-0] Copied 00000000000000000002.log to
remote storage with segment-id:
RemoteLogSegmentId{topicIdPartition=DcnVRVRSQd675ZLtCIn21A:topicB-0,
id=gcVp790dRlmFCr_0tN0NTg} (kafka.log.remote.RemoteLogManager$RLMTask:792)
[2024-05-04 08:59:28,300] INFO Closing topic-based RLMM resources
[2024-05-04 08:59:28,304] INFO Closing the instance
(org.apache.kafka.server.log.remote.metadata.storage.ConsumerTask:328)
[2024-05-04 08:59:28,308] INFO Exited from consumer task thread
(org.apache.kafka.server.log.remote.metadata.storage.ConsumerTask:151)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
