jsancio commented on code in PR #15859: URL: https://github.com/apache/kafka/pull/15859#discussion_r1595793667
########## raft/src/test/java/org/apache/kafka/raft/ElectionStateTest.java: ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.raft; + +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.Optional; +import org.apache.kafka.common.Uuid; +import org.apache.kafka.common.utils.Utils; +import org.apache.kafka.raft.generated.QuorumStateData; +import org.apache.kafka.raft.internals.ReplicaKey; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.ValueSource; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; + +final class ElectionStateTest { + @Test + void testVotedCandidateWithoutVotedId() { + ElectionState electionState = ElectionState.withUnknownLeader(5, Collections.emptySet()); + assertFalse(electionState.isVotedCandidate(ReplicaKey.of(1, Optional.empty()))); + } + + @Test + void testVotedCandidateWithoutVotedDirectoryId() { + ElectionState electionState = ElectionState.withVotedCandidate( + 5, + ReplicaKey.of(1, Optional.empty()), + Collections.emptySet() + ); + assertTrue(electionState.isVotedCandidate(ReplicaKey.of(1, Optional.empty()))); + assertTrue( + electionState.isVotedCandidate(ReplicaKey.of(1, Optional.of(Uuid.randomUuid()))) + ); + } + + @Test + void testVotedCandidateWithVotedDirectoryId() { + ReplicaKey votedKey = ReplicaKey.of(1, Optional.of(Uuid.randomUuid())); + ElectionState electionState = ElectionState.withVotedCandidate( + 5, + votedKey, + Collections.emptySet() + ); + assertFalse(electionState.isVotedCandidate(ReplicaKey.of(1, Optional.empty()))); + assertTrue(electionState.isVotedCandidate(votedKey)); + } + + @ParameterizedTest + @ValueSource(shorts = {0, 1}) + void testQuorumStateDataRoundTrip(short version) { + ReplicaKey votedKey = ReplicaKey.of(1, Optional.of(Uuid.randomUuid())); + List<ElectionState> electionStates = Arrays.asList( + ElectionState.withUnknownLeader(5, Utils.mkSet(1, 2, 3)), + ElectionState.withElectedLeader(5, 1, Utils.mkSet(1, 2, 3)), + ElectionState.withVotedCandidate(5, votedKey, Utils.mkSet(1, 2, 3)) + ); + + final List<ElectionState> expected; + if (version == 0) { + expected = Arrays.asList( + ElectionState.withUnknownLeader(5, Utils.mkSet(1, 2, 3)), + ElectionState.withElectedLeader(5, 1, Utils.mkSet(1, 2, 3)), + ElectionState.withVotedCandidate( + 5, + ReplicaKey.of(1, Optional.empty()), + Utils.mkSet(1, 2, 3) + ) + ); + } else { + expected = Arrays.asList( + ElectionState.withUnknownLeader(5, Collections.emptySet()), + ElectionState.withElectedLeader(5, 1, Collections.emptySet()), + ElectionState.withVotedCandidate(5, votedKey, Collections.emptySet()) Review Comment: `ElectionState` is the in-memory representation of the `quorum-state` file or `QuorumStateData`. When version 1 is used, `votedDirectoryId` is persisted but `voters` is not. When version 0 is used, `voters` is persisted but `votedDirectoryId` is not. The reason why we need to keep persisting `voters` in version 0 is because I want to allow the user to upgrade to the 3.8 JAR without upgrading to kraft.version 1 and then downgrade to the 3.7 JAR. To allow this, Kafka 3.8 needs to keep persisting the `voters` even though that version of Kafka doesn't use the `voters` field. If you notice, there is not method `ElectionState::voters()`. So there is no way for the latest version of Kafka to use those values. They are just there for backwards compatibility if they don't upgrade to kraft.version 1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
