lianetm commented on code in PR #15909:
URL: https://github.com/apache/kafka/pull/15909#discussion_r1596716965
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -193,11 +193,12 @@ public NetworkClientDelegate.PollResult poll(long
currentTimeMs) {
}
pollTimer.update(currentTimeMs);
if (pollTimer.isExpired() && !membershipManager.isLeavingGroup()) {
- logger.warn("Consumer poll timeout has expired. This means the
time between " +
+ logger.warn("Consumer poll timeout has expired, exceeded by {} ms.
This means the time between " +
Review Comment:
Hey, good point, it would actually take this a step further, where indeed
should be more useful. As @AndrewJSchofield pointed, the HB manager will notice
sooner in practice (even sooner than the HB interval), but we do know when the
next poll happens, so can definitely get a more accurate exceed time
(in-between calls to poll, which translates to poll events handled in this same
manager). On it...thanks for the comments!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
