gharris1727 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1596952044
########## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java: ########## @@ -267,6 +267,18 @@ public String memberId() { return JoinGroupRequest.UNKNOWN_MEMBER_ID; } + @Override + protected void handlePollTimeoutExpiry() { Review Comment: Yeah the tick thread stage is a best effort and can be misleading. However, if something has blocked long enough to cause a poll timeout, its likely enough to continue for the additional time it requires for the heartbeat thread to notice. I think the ideal use-case I see is that this error pops up in a worker log 3 or more times before an operator has a chance to remediate it, and if the majority of logs blame connector-xyz, the operator can STOP that connector. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org