https://bugs.kde.org/show_bug.cgi?id=459723
--- Comment #6 from Eoin O'Neill <eoinoneill1...@gmail.com> --- Git commit 305fd3fb947a0c11d9219a56555dafaf5162fd31 by Eoin O'Neill. Committed on 22/11/2022 at 07:47. Pushed by eoinoneill into branch 'master'. Add a plethora of missing autokey implementations for movement. There are two problems right now (in general) with autokey compared to previous versions of Krita. 1) Krita was originally heavily reliant on using KisTransactions for autokeying content in a way that essentially inherited. Since dmitry made some changes to the way transactions are applied during brush strokes that allowed them to be multi threaded, this behavior had to be fixed in a previous commit to prevent a data race resuling in a nasty crash on autokey. This means we lost some of the "automatic" autokey behavior and it needs to be reimplemented in a few key strategies in order to achieve parity with older versions. In the case of this particular bug fix, I missed a few edge cases when dealing with raster keyframes. 2) As a result of 1, there's a lot of areas of the code base where we're definitely repeating ourselves. Long term, we should really try to come up with a logical way to reuse any autokey related stroke strategy behavior so that any stroke that needs to respect users autokey wishes can do so with just a few function calls or configurations. For now, there's no real issue with repeating ourselves just to fix regressions. M +19 -0 libs/ui/tool/strokes/move_stroke_strategy.cpp M +3 -0 plugins/tools/basictools/kis_tool_move.cc M +19 -0 plugins/tools/basictools/strokes/move_selection_stroke_strategy.cpp M +13 -0 plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.cpp M +12 -0 plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp https://invent.kde.org/graphics/krita/commit/305fd3fb947a0c11d9219a56555dafaf5162fd31 -- You are receiving this mail because: You are watching all bug changes.
