https://bugs.kde.org/show_bug.cgi?id=470121

Mark Wielaard <m...@klomp.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |CONFIRMED
     Ever confirmed|0                           |1
                 CC|                            |m...@klomp.org

--- Comment #2 from Mark Wielaard <m...@klomp.org> ---
Urgh, that is my fault:

commit 6fc239ed47b44b82fb14849159f5b22132b6ca94
Author: Mark Wielaard <m...@klomp.org>
Date:   Fri Apr 21 18:13:14 2023 +0200

    Add use strict and use warnings to perl callgrind scripts

    This way we can simply use #! /usr/bin/env perl and don't need env -S
    and perl -w flags which might confuse some packaging utilities.

But I clearly never tested callgrind_control and it also doesnt seem to have
any tests (callgrind_annotate, the other perl script does have two tests
callgrind/tests/ann{1,2}.vgtest).

I quickly tested by hand and simply removing use strict seems to make
everything work as expected.
So unless it is really easy to make the perl script "strict" I would recommend
going with simply removing the use strict;

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to