https://bugs.kde.org/show_bug.cgi?id=447989
--- Comment #8 from David Benjamin <david...@google.com> --- (In reply to Paul Floyd from comment #7) > I think that in this case I would just add sha512 tests to > none/tests/fp_and_simd (or fp_and_simd_v82 - I'm not sure what the minimum > version is for sha512). > > Otherwise I just added a section to README_DEVELOPERS on writing regression > tests. Ah, perfect! Thanks, that's all really helpful! I think I've gotten the start of it working. A couple questions before I finish this up: Regarding the generating the expected files by running the test, I assume those just record what my patch does. I.e. if my patch were wrong, the wrong things would get recorded in expectations. I've run my test against BoringSSL's use of these instructions, so I'm fairly confident it's correct. But it seems to me we can do better: just synthesize the expected output by running the instructions directly, without involving valgrind at all. I don't suppose this exists? (If not, no big deal. Like I said, I've already manually tested this against BoringSSL.) Regarding where to put the tests, these are indeed Armv8.2 instructions, but I noticed fp_and_simd_v82's prerequisite is actually the fphp (floating point half-precision) extension. These instructions are from a separate extension. My test device happens to have both but, in principle, they're orthogonal. Should I still put them in fp_and_simd_v82 or make a new one? I'm guessing a new one would be preferable, though this would get pretty large fast. Arm, alas, has lots and lots of extensions. E.g. I noticed that the Armv8.0 cryptography instructions are just in the plain fp_and_simd test, with no prereq, but not all Armv8.0 chips have those instructions. (It's pretty rare to omit them, but I think the Raspberry Pis don't?) If I make a new one, should I just copy all the various helper macros at the top of that file, or try to extract them somewhere? Seems they're in a few places already. -- You are receiving this mail because: You are watching all bug changes.
