On 13 February 2014 11:36, Robin Watts <robin.wa...@artifex.com> wrote: > Secondly, for people who happen to be using small positive integers for > the cmsContext value, Marti has a horrible hack/"clever piece of > engineering" in there that recognises this case and works around it.
Sure, and I fully agree the number of people going to be using integer values in the callback should be very small, but this does not fix the problem with passing the address of a small struct and valgrind issuing hundreds of warnings about uninitialised values. At the moment if you ship lcms2 as an update in fedora, colord crashes at boot and sends an automated abrt bug to the bugtracker against the colord component. As the backtraces are similar, but not the same, the bugs won't be auto-duped. I'm sure colord isn't the only app that using the _THR() functions for it's own purposes. I'm scrambling to convert the colord codebase to the new API so I can issue an unplanned-update along with the lcms2 update. > If you're resigning yourself to adding a new call to the code, you might > as well just change to the newer context handling. Well, my point was that without this new runtime method we'd use the old ABI, although I agree what you say about the global variable thing. If Marti does go with an API bump, it might be a good time to get rid of the cruft, i.e. remove cmsOpenProfileFromMemTHR and just have a cmsOpenProfileFromMem() with a cmsContext parameter. If there's no API bump to be done, we need to communicate this much better to lcms2 consumers and give them time to test against the new ABI. FWIW, a soname bump would be a huge pain for the distros as there is a ton of stuff all depending on lcms2 that needs rebuilding and testing, but possibly preferable than apps and services randomly crashing. Richard ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ Lcms-user mailing list Lcms-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lcms-user
