Hi! Thanks for taking a look, you are right! I think my mistake was that I forgot to negate the bools, which lead me to believe that bSkipX/Y were always true.
All the best, Krisztian On 22 June 2015 at 13:04, Eike Rathke <er...@redhat.com> wrote: > Hi Krisztian, > > On Sunday, 2015-06-21 22:11:44 +0200, Krisztian Pinter wrote: > > > I also think I found some dead code, if someone could shed some light on > > the history of it, I would appreciate it. This is my patch which removes > > it: https://gerrit.libreoffice.org/#/c/16351/ > > ScOutputData::DrawExtraShadow gets called with all false parameters which > > causes it to just skip any sort of drawing. It seems to be leftovers from > > some refactoring. > > I don't think so. I haven't investigated thoroughly, but to me it looks > like only the shadow of the surrounding outer cells is suppressed in the > false case. All inner cells still have their shadow(s) drawn. > > bool bSkipY = ( nArrY==0 && !bTop ) || ( nArrY+1 == nArrCount && > !bBottom ); > bool bSkipX = ( nArrX==nX1 && !bLeft ) || ( nArrX==nX2+2 && !bRight ); > > does not skip for 0 < nArrY < nArrCount-1 and nX1 < nArrX < nX2+2 > > Eike > > -- > LibreOffice Calc developer. Number formatter stricken i18n > transpositionizer. > GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 > 2D3A > Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ > Care about Free Software, support the FSFE https://fsfe.org/support/?erack >
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice