On Thu, Nov 03, 2011 at 10:46:36PM +0100, Philipp Weissenbacher wrote: > On 29 October 2011 01:02, Norbert Thiebaud <nthieb...@gmail.com> wrote: > > On Fri, Oct 28, 2011 at 3:11 PM, Philipp Weissenbacher > > <p.weissenbac...@gmail.com> wrote:
>>>> Out of curiosity, how did you set-up your repos ? (pure git clone, >>>> using the tar.gz primer method ? ) >>> I used git clone git://anongit.freedesktop.org/git/core/ >>> And then followed the patch handling guideline to generate the patches. >>> Am I doing it wrong? >> You never ran autogen.sh ? never try to make the product ? >> ah... that would explain it indeed. >> In any case it might be a good exercise to try to actually do a >> build, since it is good practice to try to at least compile when >> doing any sort of change to the source code. > Sure, I will try to build it. > I wasn't sure if translating comments was serious enough a change to > do that. I would tend to think that indeed, building LibreOffice just to translate comments is rather onerous a cost; I would like that we do not ask that of people. I've modified the Patch Handling Guidelines with instructions on how to enable the git hooks without building. -- Lionel _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice