Hi, I have submitted a patch for review:
https://gerrit.libreoffice.org/3122 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/3122/1 fdo#51656 : Mean value line starts in wrong place in column graph Change-Id: I2389687e54cec4c0e873bcc120cc21b3c3d11d78 --- M chart2/source/tools/ChartTypeHelper.cxx M chart2/source/view/charttypes/VSeriesPlotter.cxx 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/chart2/source/tools/ChartTypeHelper.cxx b/chart2/source/tools/ChartTypeHelper.cxx index 51b760d..4585d79 100644 --- a/chart2/source/tools/ChartTypeHelper.cxx +++ b/chart2/source/tools/ChartTypeHelper.cxx @@ -433,7 +433,7 @@ if( aChartTypeName.match(CHART2_SERVICE_NAME_CHARTTYPE_COLUMN) || aChartTypeName.match(CHART2_SERVICE_NAME_CHARTTYPE_BAR) || aChartTypeName.match(CHART2_SERVICE_NAME_CHARTTYPE_CANDLESTICK) ) - return true; + return true; // this 'true' here causes a 'default x-axis shift' in the above mentioned three charttypes. } return false; } diff --git a/chart2/source/view/charttypes/VSeriesPlotter.cxx b/chart2/source/view/charttypes/VSeriesPlotter.cxx index 6e114dd..9387666 100644 --- a/chart2/source/view/charttypes/VSeriesPlotter.cxx +++ b/chart2/source/view/charttypes/VSeriesPlotter.cxx @@ -1017,7 +1017,7 @@ double fLogicY = aCalculatedPoints[nP].Y; double fLogicZ = 0.0;//dummy - m_pPosHelper->doLogicScaling( &fLogicX, &fLogicY, &fLogicZ ); + //m_pPosHelper->doLogicScaling( &fLogicX, &fLogicY, &fLogicZ ); --- this creates bug#51656 if( !::rtl::math::isNan(fLogicX) && !::rtl::math::isInf(fLogicX) && !::rtl::math::isNan(fLogicY) && !::rtl::math::isInf(fLogicY) -- To view, visit https://gerrit.libreoffice.org/3122 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2389687e54cec4c0e873bcc120cc21b3c3d11d78 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Prashant Pandey <prashant3.yi...@gmail.com> _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice