Use memdup_user() helper instead of open-coding to simplify the code.

Signed-off-by: Geliang Tang <geliangt...@gmail.com>
---
 drivers/firmware/efi/test/efi_test.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/firmware/efi/test/efi_test.c 
b/drivers/firmware/efi/test/efi_test.c
index 8cd578f..08129b7 100644
--- a/drivers/firmware/efi/test/efi_test.c
+++ b/drivers/firmware/efi/test/efi_test.c
@@ -71,18 +71,13 @@ copy_ucs2_from_user_len(efi_char16_t **dst, efi_char16_t 
__user *src,
        if (!access_ok(VERIFY_READ, src, 1))
                return -EFAULT;
 
-       buf = kmalloc(len, GFP_KERNEL);
-       if (!buf) {
+       buf = memdup_user(src, len);
+       if (IS_ERR(buf)) {
                *dst = NULL;
-               return -ENOMEM;
+               return PTR_ERR(buf);
        }
        *dst = buf;
 
-       if (copy_from_user(*dst, src, len)) {
-               kfree(buf);
-               return -EFAULT;
-       }
-
        return 0;
 }
 
-- 
2.9.3

Reply via email to