Hi Tom，
On 02/28/2021 08:54 AM, Tom Rix wrote:
CAUTION: This message has originated from an External Source. Please use proper
judgment and caution when opening attachments, clicking links, or responding to
this email.
On 2/26/21 1:23 PM, Lizhi Hou wrote:
Hi Tom,
snip
I also do not see a pragma pack, usually this is set of 1 so the compiler does
not shuffle elements, increase size etc.
This data structure is shared with other tools. And the structure is well
defined with reasonable alignment. It is compatible with all compilers we have
tested. So pragma pack is not necessary.
You can not have possibly tested all the configurations since the kernel
supports many arches and compilers.
If the tested existing alignment is ok, pragma pack should be a noop on your
tested configurations.
And help cover the untested configurations.
Got it. I will add pragma pack(1).
Lizhi
Tom
