On Thu, Apr 08, 2021 at 11:20:11AM +0200, David Hildenbrand wrote:
> Random drivers should not override a user configuration of core knobs
> (e.g., CONFIG_DMA_CMA=n). Use "imply" instead, to still respect
> dependencies and manual overrides.
>
> "This is similar to "select" as it enforces a lower limit on another
> symbol except that the "implied" symbol's value may still be set to n
> from a direct dependency or with a visible prompt."
>
> Implying DRM_CMA should be sufficient, as that depends on CMA.
^ DMA_CMA
>
> Note: If this is a real dependency, we should use "depends on DMA_CMA"
> instead - but I assume the driver can work without CMA just fine --
> esp. when we wouldn't have HAVE_DMA_CONTIGUOUS right now.
>
> Signed-off-by: David Hildenbrand <da...@redhat.com>
> ---
> drivers/gpu/drm/aspeed/Kconfig | 3 +--
> drivers/gpu/drm/etnaviv/Kconfig | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/aspeed/Kconfig b/drivers/gpu/drm/aspeed/Kconfig
> index 5e95bcea43e9..a055f763d230 100644
> --- a/drivers/gpu/drm/aspeed/Kconfig
> +++ b/drivers/gpu/drm/aspeed/Kconfig
> @@ -6,9 +6,8 @@ config DRM_ASPEED_GFX
> depends on MMU
> select DRM_KMS_HELPER
> select DRM_KMS_CMA_HELPER
> - select DMA_CMA if HAVE_DMA_CONTIGUOUS
> - select CMA if HAVE_DMA_CONTIGUOUS
> select MFD_SYSCON
> + imply DRM_CMA
Ditto
> help
> Chose this option if you have an ASPEED AST2500 SOC Display
> Controller (aka GFX).
> diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers/gpu/drm/etnaviv/Kconfig
> index faa7fc68b009..5f5576b7221a 100644
> --- a/drivers/gpu/drm/etnaviv/Kconfig
> +++ b/drivers/gpu/drm/etnaviv/Kconfig
> @@ -9,9 +9,8 @@ config DRM_ETNAVIV
> select THERMAL if DRM_ETNAVIV_THERMAL
> select TMPFS
> select WANT_DEV_COREDUMP
> - select CMA if HAVE_DMA_CONTIGUOUS
> - select DMA_CMA if HAVE_DMA_CONTIGUOUS
> select DRM_SCHED
> + imply DMA_CMA
> help
> DRM driver for Vivante GPUs.
>
> --
> 2.30.2
>
--
Sincerely yours,
Mike.
