On Thu, 7 Dec 2023 17:19:24 -0500
Mathieu Desnoyers <mathieu.desnoy...@efficios.com> wrote:
> On 2023-12-07 17:16, Steven Rostedt wrote:
>
> [...]
>
> > diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> > index 8d2a4f00eca9..b10deb8a5647 100644
> > --- a/kernel/trace/ring_buffer.c
> > +++ b/kernel/trace/ring_buffer.c
> > @@ -3424,23 +3424,27 @@ static void dump_buffer_page(struct
> > buffer_data_page *bpage,
> > case RINGBUF_TYPE_TIME_EXTEND:
> > delta = rb_event_time_stamp(event);
> > ts += delta;
> > - pr_warn(" [%lld] delta:%lld TIME EXTEND\n", ts, delta);
> > + pr_warn(" %x: [%lld] delta:%lld TIME EXTEND\n",
>
> Please prefix hex values with "0x", as in:
>
> pr_warn(" 0x%x: [%lld] delta:%lld TIME EXTEND\n"
>
> Otherwise it can be confusing.
>
Heh, sure. I'm so use to looking at hex for the ring buffer offsets, that I
seldom add the 0x in my debug anymore. But as this is permanent, and not
just a one off print, I'll make the update and post a v2.
Thanks,
-- Steve
