On 4 June 2018 at 08:46, Hans Verkuil <hverk...@xs4all.nl> wrote: > From: Hans Verkuil <hans.verk...@cisco.com> > > Add support for requests to vim2m. > > Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> > --- > drivers/media/platform/vim2m.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c > index 5cb077294734..1efc8033320f 100644 > --- a/drivers/media/platform/vim2m.c > +++ b/drivers/media/platform/vim2m.c > @@ -380,8 +380,18 @@ static void device_run(void *priv) > src_buf = v4l2_m2m_next_src_buf(ctx->fh.m2m_ctx); > dst_buf = v4l2_m2m_next_dst_buf(ctx->fh.m2m_ctx); > > + /* Apply request controls if needed */ > + if (src_buf->vb2_buf.req_obj.req)
Nit: it seems we don't need this check? > + v4l2_ctrl_request_setup(src_buf->vb2_buf.req_obj.req, > + &ctx->hdl); > + > device_process(ctx, src_buf, dst_buf); > > + /* Complete request controls if needed */ > + if (src_buf->vb2_buf.req_obj.req) Ditto. > + v4l2_ctrl_request_complete(src_buf->vb2_buf.req_obj.req, > + &ctx->hdl); > + > /* Run delayed work, which simulates a hardware irq */ > schedule_delayed_work(&dev->work_run, > msecs_to_jiffies(ctx->transtime)); > } -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar
