On Fri, Sep 07, 2018 at 11:33:23AM +0300, Felipe Balbi wrote: > > Hi Greg, > > "Gopal, Saranya" <saranya.go...@intel.com> writes: > >> > diff --git a/drivers/usb/roles/intel-xhci-usb-role-switch.c > >> b/drivers/usb/roles/intel-xhci-usb-role-switch.c > >> > index dad2d19..0d1ea82 100644 > >> > --- a/drivers/usb/roles/intel-xhci-usb-role-switch.c > >> > +++ b/drivers/usb/roles/intel-xhci-usb-role-switch.c > >> > @@ -25,6 +25,9 @@ > >> > #define SW_VBUS_VALID BIT(24) > >> > #define SW_IDPIN_EN BIT(21) > >> > #define SW_IDPIN BIT(20) > >> > +#define SW_SWITCH_EN_CFG0 BIT(16) > >> > >> Why is this not in the correct sorted order with the items above it? > > they are sorted in descending order. > > /* register definition */ > #define DUAL_ROLE_CFG0 0x68 > #define SW_VBUS_VALID BIT(24) > #define SW_IDPIN_EN BIT(21) > #define SW_IDPIN BIT(20)
Ugh, you are right, that's what I get for trying to review code before my coffee has kicked in... Sorry about that. greg k-h
