On Mon, Feb 03, 2014 at 01:59:38PM +0530, Sachin Kamat wrote:
> Pass value instead of address as expected by 'usb_ep_set_maxpacket_limit'.
> Fixes the following compilation error introduced by commit e117e742d310
> ("usb: gadget: add "maxpacket_limit" field to struct usb_ep"):
>
> drivers/usb/gadget/s3c2410_udc.c: In function ‘s3c2410_udc_reinit’:
> drivers/usb/gadget/s3c2410_udc.c:1632:3: error:
> cannot take address of bit-field ‘maxpacket’
> usb_ep_set_maxpacket_limit(&ep->ep, &ep->ep.maxpacket);
>
> Signed-off-by: Sachin Kamat <sachin.ka...@linaro.org>
> Reviewed-by: Robert Baldyga <r.bald...@samsung.com>is this still needed for -rc4 ? > --- > drivers/usb/gadget/s3c2410_udc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/s3c2410_udc.c > b/drivers/usb/gadget/s3c2410_udc.c > index f04b2c3154de..dd9678f85c58 100644 > --- a/drivers/usb/gadget/s3c2410_udc.c > +++ b/drivers/usb/gadget/s3c2410_udc.c > @@ -1629,7 +1629,7 @@ static void s3c2410_udc_reinit(struct s3c2410_udc *dev) > ep->ep.desc = NULL; > ep->halted = 0; > INIT_LIST_HEAD(&ep->queue); > - usb_ep_set_maxpacket_limit(&ep->ep, &ep->ep.maxpacket); > + usb_ep_set_maxpacket_limit(&ep->ep, ep->ep.maxpacket); > } > } > > -- > 1.7.9.5 > -- balbi
signature.asc
Description: Digital signature
