Dear Marcin Wojtas,

On Thu, 13 Nov 2014 00:49:50 +0100, Marcin Wojtas wrote:
> This commit fixes ehci-orion operation in big-endian mode by enabling byteswap
> when accessing registers using 'rdl' and 'wrl' macros.
> 
> Signed-off-by: Grzegorz Jaszczyk <j...@semihalf.com>
> Signed-off-by: Marcin Wojtas <m...@semihalf.com>
> Reviewed-by: Gregory CLEMENT <gregory.clem...@free-electrons.com>

Tested-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com>

Indeed, on Armada XP GP, without this patch, no USB devices are
detected when the kernel runs in big endian mode. With this patch
applied, a USB key is properly detected and I can mount/access it.

Moreover, using {readl,writel}_relaxed() is safe here: even though
those I/O accessors are not yet available on all architectures, the
ehci-orion driver has a "depends on PLAT_ORION", so it can only be
enabled on ARM, which has those accessors available.

Greg, Alan, could you apply Marcin's patch?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to