On 2/19/20 6:50 PM, Krzysztof Kozlowski wrote:
> The ioreadX() helpers have inconsistent interface.  On some architectures
> void *__iomem address argument is a pointer to const, on some not.
> 
> Implementations of ioreadX() do not modify the memory under the address
> so they can be converted to a "const" version for const-safety and
> consistency among architectures.
> 
> Signed-off-by: Krzysztof Kozlowski <k...@kernel.org>

Acked-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>

Regards,

        Hans

> ---
>  drivers/media/platform/fsl-viu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/fsl-viu.c 
> b/drivers/media/platform/fsl-viu.c
> index 81a8faedbba6..991d9dc82749 100644
> --- a/drivers/media/platform/fsl-viu.c
> +++ b/drivers/media/platform/fsl-viu.c
> @@ -34,7 +34,7 @@
>  /* Allow building this driver with COMPILE_TEST */
>  #if !defined(CONFIG_PPC) && !defined(CONFIG_MICROBLAZE)
>  #define out_be32(v, a)       iowrite32be(a, (void __iomem *)v)
> -#define in_be32(a)   ioread32be((void __iomem *)a)
> +#define in_be32(a)   ioread32be((const void __iomem *)a)
>  #endif
>  
>  #define BUFFER_TIMEOUT               msecs_to_jiffies(500)  /* 0.5 seconds */
> 

Reply via email to