-----Original Message-----
From: Christophe <christophe.le...@csgroup.eu> To: Ekaterina <ees...@astralinux.ru>; Zhao <qiang.z...@nxp.com> Cc: lvc-project <lvc-proj...@linuxtesting.org>; netdev <net...@vger.kernel.org>; linux-kernel <linux-ker...@vger.kernel.org>; Eric <eduma...@google.com>; Jakub <k...@kernel.org>; Paolo <pab...@redhat.com>; linuxppc-dev <linuxppc-dev@lists.ozlabs.org>; David <da...@davemloft.net> Date: Monday, 9 January 2023 6:49 PM MSK Subject: Re: [PATCH] net-wan: Add check for NULL for utdm in ucc_hdlc_probe Le 23/12/2022 à 15:32, Ekaterina Esina a écrit : > [Vous ne recevez pas souvent de courriers de ees...@astralinux.ru. Découvrez > pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > If uhdlc_priv_tsa != 1 then utdm is not initialized. > And if ret != NULL then goto undo_uhdlc_init, where utdm is dereferenced. > Same if dev == NULL. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Ekaterina Esina <ees...@astralinux.ru> > --- > drivers/net/wan/fsl_ucc_hdlc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c > index 22edea6ca4b8..2ddb0f71e648 100644 > --- a/drivers/net/wan/fsl_ucc_hdlc.c > +++ b/drivers/net/wan/fsl_ucc_hdlc.c > @@ -1243,7 +1243,9 @@ static int ucc_hdlc_probe(struct platform_device *pdev) > free_dev: > free_netdev(dev); > undo_uhdlc_init: > - iounmap(utdm->siram); > + if (utdm != NULL) { > + iounmap(utdm->siram); > + } If utdm being NULL is a problem here, isn't it also a problem in the iounmap below ? > unmap_si_regs: > iounmap(utdm->si_regs); > free_utdm: > -- > 2.30.2 > Yes, below the check is also needed. I guess I should send a new patch with > both checks Best wishes, Ekaterina Esina
