Frédéric Brière <fbri...@fbriere.net> writes:

> +    [ -e "$CONFFILE" ] || return 0

It probably doesn't matter, but I'd use -f here.

> +    echo "Obsolete conffile $CONFFILE has been modified by you."
> +    echo "Saving as $CONFFILE.dpkg-bak ..."
> +    mv -f "$CONFFILE" "$CONFFILE".dpkg-bak

I would tend to not do this and instead just leave the file in place since
it does still work.  I think it's arguable that moving the file aside such
that it is no longer active would constitute discarding user configuration
in a way that logcheck shouldn't, Policy-wise, do.

Otherwise, looks great here.

-- 
Russ Allbery (r...@debian.org)               <http://www.eyrie.org/~eagle/>



_______________________________________________
Logcheck-devel mailing list
Logcheck-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/logcheck-devel

Reply via email to