Your message dated Sun, 26 Jan 2014 19:03:37 +0000
with message-id <e1w7uzz-00022o...@franck.debian.org>
and subject line Bug#645588: fixed in logcheck 1.3.16
has caused the Debian Bug report #645588,
regarding Shouldn't recreate alias on upgrades
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
645588: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=645588
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: logcheck
Version: 1.3.14
Severity: normal
Tags: patch
Hi
I don't want the logcheck email alias because I configure logcheck to
send email to a different address, but it keeps getting re-added on
upgrades.
I've prepared a patch to only add the alias on install, not on
upgrades, but I've noticed some small issues with the rest of the
postinst (tests which could be simplified and tabs with different size
expectations depending on the code block you're looking at), so I'm
attaching a series of patches on top of current git to fix these.
Thanks,
--
Loïc Minier
>From 0bb0adbaa4e2a84ad16b1871efa729cfd90eff2a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Minier?= <l...@debian.org>
Date: Mon, 17 Oct 2011 09:22:36 +0200
Subject: [PATCH 1/4] Add logcheck alias on install not on upgrade
---
debian/logcheck.postinst | 14 ++++++++------
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/debian/logcheck.postinst b/debian/logcheck.postinst
index 849ad98..7032323 100644
--- a/debian/logcheck.postinst
+++ b/debian/logcheck.postinst
@@ -47,13 +47,15 @@ case "$1" in
adduser --quiet logcheck adm || true
fi
- # add logcheck to /etc/aliases
- if [ -f /etc/aliases ] || [ -L /etc/aliases ]; then
- if ! grep -qi "^logcheck[[:space:]]*:" /etc/aliases; then
- echo "logcheck: root" >> /etc/aliases
- test -x "$(command -v newaliases)" && newaliases || :
+ # add logcheck to /etc/aliases on install; not on upgrade
+ if [ -z "$2" ]; then
+ if [ -f /etc/aliases ] || [ -L /etc/aliases ]; then
+ if ! grep -qi "^logcheck[[:space:]]*:" /etc/aliases; then
+ echo "logcheck: root" >> /etc/aliases
+ test -x "$(command -v newaliases)" && newaliases || :
+ fi
fi
- fi
+ fi
# give logcheck system user a real name unless it has one.
if [ -z "$(getent passwd logcheck | cut -d: -f5)" ]; then
--
1.7.5.4
>From d2e57486d3197297388494ed210e90b68d8fe23b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Minier?= <l...@debian.org>
Date: Mon, 17 Oct 2011 09:23:15 +0200
Subject: [PATCH 2/4] Use [ -z ... ] rather than [ ! -n ... ]
---
debian/logcheck.postinst | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/debian/logcheck.postinst b/debian/logcheck.postinst
index 7032323..d3dfbfc 100644
--- a/debian/logcheck.postinst
+++ b/debian/logcheck.postinst
@@ -63,7 +63,7 @@ case "$1" in
fi
# Add logcheck mail header on install
- if [ ! -n "$2" ] && [ ! -f /etc/logcheck/header.txt ]; then
+ if [ -z "$2" ] && [ ! -f /etc/logcheck/header.txt ]; then
cp -p /usr/share/logcheck/header.txt /etc/logcheck
fi
@@ -72,7 +72,7 @@ case "$1" in
chgrp -R logcheck /etc/logcheck || true
# Set Permissions on install, not upgrade
- if [ ! -n "$2" ]; then
+ if [ -z "$2" ]; then
chmod 2750 /etc/logcheck/ignore.d.paranoid || true
chmod 2750 /etc/logcheck/ignore.d.workstation || true
chmod 2750 /etc/logcheck/ignore.d.server || true
--
1.7.5.4
>From 11a96a81ec8bade1d4855495611452552cdfbe67 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Minier?= <l...@debian.org>
Date: Mon, 17 Oct 2011 09:28:49 +0200
Subject: [PATCH 3/4] Fix indentation and whitespaces in postinsts
Also, call ":" in empty case statements.
---
debian/logcheck-database.postinst | 60 ++++++++--------
debian/logcheck.postinst | 138 ++++++++++++++++++------------------
2 files changed, 99 insertions(+), 99 deletions(-)
diff --git a/debian/logcheck-database.postinst b/debian/logcheck-database.postinst
index 4ff4888..c8f5337 100644
--- a/debian/logcheck-database.postinst
+++ b/debian/logcheck-database.postinst
@@ -29,39 +29,39 @@ set -e
confdir="/etc/logcheck"
case "$1" in
- configure)
- # Remove old sarge mv logcheck-data configfiles if unchanged
- if [ -n "$2" ] && dpkg --compare-versions "$2" lt "1.2.48"; then
- proftpd_sum=$(sha1sum '/etc/logcheck/ignore.d.paranoid/proftpd' 2>/dev/null \
- | awk '{print $1}')
- imap_sum=$(sha1sum '/etc/logcheck/ignore.d.paranoid/imap' 2>/dev/null \
- | awk '{print $1}')
- anacron_sum=$(sha1sum '/etc/logcheck/ignore.d.workstation/anacron' 2>/dev/null \
- | awk '{print $1}')
- if [ "${proftpd_sum}" = "da39a3ee5e6b4b0d3255bfef95601890afd80709" ]; then
- rm -rf /etc/logcheck/ignore.d.paranoid/proftpd
- fi
- if [ "${imap_sum}" = "9d4e9db1bd0c5cdd5ea3ba8875e628bf50cf1f5f" ]; then
- rm -rf /etc/logcheck/ignore.d.paranoid/imap
- fi
- if [ "${anacron_sum}" = "78e753ffeff32474a805a7654aa99a07076b6975" ]; then
- rm -rf /etc/logcheck/ignore.d.workstation/anacron
- fi
- fi
+ configure)
+ # Remove old sarge mv logcheck-data configfiles if unchanged
+ if [ -n "$2" ] && dpkg --compare-versions "$2" lt "1.2.48"; then
+ proftpd_sum=$(sha1sum '/etc/logcheck/ignore.d.paranoid/proftpd' 2>/dev/null \
+ | awk '{print $1}')
+ imap_sum=$(sha1sum '/etc/logcheck/ignore.d.paranoid/imap' 2>/dev/null \
+ | awk '{print $1}')
+ anacron_sum=$(sha1sum '/etc/logcheck/ignore.d.workstation/anacron' 2>/dev/null \
+ | awk '{print $1}')
+ if [ "${proftpd_sum}" = "da39a3ee5e6b4b0d3255bfef95601890afd80709" ]; then
+ rm -rf /etc/logcheck/ignore.d.paranoid/proftpd
+ fi
+ if [ "${imap_sum}" = "9d4e9db1bd0c5cdd5ea3ba8875e628bf50cf1f5f" ]; then
+ rm -rf /etc/logcheck/ignore.d.paranoid/imap
+ fi
+ if [ "${anacron_sum}" = "78e753ffeff32474a805a7654aa99a07076b6975" ]; then
+ rm -rf /etc/logcheck/ignore.d.workstation/anacron
+ fi
+ fi
- if getent group logcheck >/dev/null; then
- chgrp -R logcheck /etc/logcheck
- fi
- ;;
+ if getent group logcheck >/dev/null; then
+ chgrp -R logcheck /etc/logcheck
+ fi
+ ;;
- abort-upgrade|abort-remove|abort-deconfigure)
+ abort-upgrade|abort-remove|abort-deconfigure)
+ :
+ ;;
- ;;
-
- *)
- echo "postinst called with unknown argument \`$1'" >&2
- exit 1
- ;;
+ *)
+ echo "postinst called with unknown argument \`$1'" >&2
+ exit 1
+ ;;
esac
# dh_installdeb will replace this with shell code automatically
diff --git a/debian/logcheck.postinst b/debian/logcheck.postinst
index d3dfbfc..650a90f 100644
--- a/debian/logcheck.postinst
+++ b/debian/logcheck.postinst
@@ -21,80 +21,80 @@ set -e
# `abort-remove' or `abort-deconfigure'.
case "$1" in
- configure)
- # Add logcheck user
- # check for logcheck user or bad version without home
- # touch cron job on updating accounts to fix #284788
- if ! getent passwd logcheck > /dev/null; then
- adduser --quiet --system --home /var/lib/logcheck --no-create-home \
- --group logcheck ||true
- touch /etc/cron.d/logcheck || true
- fi
-
- # check for logcheck group in case account exists without group
- if ! getent group logcheck >/dev/null; then
- addgroup --system logcheck
- usermod -g logcheck logcheck
- fi
-
- # make sure the home directory exists
- if [ ! -d "$(getent passwd logcheck | cut -d: -f6)" ]; then
- usermod -d /var/lib/logcheck logcheck > /dev/null || true
- fi
-
- # check for logcheck in adm group
- if ! getent group adm | grep logcheck > /dev/null; then
- adduser --quiet logcheck adm || true
- fi
-
- # add logcheck to /etc/aliases on install; not on upgrade
- if [ -z "$2" ]; then
- if [ -f /etc/aliases ] || [ -L /etc/aliases ]; then
- if ! grep -qi "^logcheck[[:space:]]*:" /etc/aliases; then
- echo "logcheck: root" >> /etc/aliases
- test -x "$(command -v newaliases)" && newaliases || :
- fi
+ configure)
+ # Add logcheck user
+ # check for logcheck user or bad version without home
+ # touch cron job on updating accounts to fix #284788
+ if ! getent passwd logcheck > /dev/null; then
+ adduser --quiet --system --home /var/lib/logcheck --no-create-home \
+ --group logcheck || true
+ touch /etc/cron.d/logcheck || true
fi
- fi
- # give logcheck system user a real name unless it has one.
- if [ -z "$(getent passwd logcheck | cut -d: -f5)" ]; then
- chfn -f 'logcheck system account' logcheck
- fi
+ # check for logcheck group in case account exists without group
+ if ! getent group logcheck >/dev/null; then
+ addgroup --system logcheck
+ usermod -g logcheck logcheck
+ fi
+
+ # make sure the home directory exists
+ if [ ! -d "$(getent passwd logcheck | cut -d: -f6)" ]; then
+ usermod -d /var/lib/logcheck logcheck > /dev/null || true
+ fi
- # Add logcheck mail header on install
- if [ -z "$2" ] && [ ! -f /etc/logcheck/header.txt ]; then
- cp -p /usr/share/logcheck/header.txt /etc/logcheck
+ # check for logcheck in adm group
+ if ! getent group adm | grep logcheck > /dev/null; then
+ adduser --quiet logcheck adm || true
+ fi
+
+ # add logcheck to /etc/aliases on install; not on upgrade
+ if [ -z "$2" ]; then
+ if [ -f /etc/aliases ] || [ -L /etc/aliases ]; then
+ if ! grep -qi "^logcheck[[:space:]]*:" /etc/aliases; then
+ echo "logcheck: root" >> /etc/aliases
+ test -x "$(command -v newaliases)" && newaliases || :
+ fi
fi
+ fi
+
+ # give logcheck system user a real name unless it has one.
+ if [ -z "$(getent passwd logcheck | cut -d: -f5)" ]; then
+ chfn -f 'logcheck system account' logcheck
+ fi
+
+ # Add logcheck mail header on install
+ if [ -z "$2" ] && [ ! -f /etc/logcheck/header.txt ]; then
+ cp -p /usr/share/logcheck/header.txt /etc/logcheck
+ fi
+
+ # Unconditionalizing this for now as we have files that are
+ # unreadable upon upgrade. <ttrox...@debian.org>
+ chgrp -R logcheck /etc/logcheck || true
+
+ # Set Permissions on install, not upgrade
+ if [ -z "$2" ]; then
+ chmod 2750 /etc/logcheck/ignore.d.paranoid || true
+ chmod 2750 /etc/logcheck/ignore.d.workstation || true
+ chmod 2750 /etc/logcheck/ignore.d.server || true
+ chmod 2750 /etc/logcheck/cracking.d || true
+ chmod 2750 /etc/logcheck/cracking.ignore.d || true
+ chmod 2750 /etc/logcheck/violations.d || true
+ chmod 2750 /etc/logcheck/violations.ignore.d || true
+ chmod -R g+rX /etc/logcheck || true
+ fi
+ chown -R logcheck:logcheck /var/lib/logcheck || true
+ chmod 0770 /var/lib/logcheck || true
+
+ ;;
+
+ abort-upgrade|abort-remove|abort-deconfigure)
+ :
+ ;;
- # Unconditionalizing this for now as we have files that are
- # unreadable upon upgrade. <ttrox...@debian.org>
- chgrp -R logcheck /etc/logcheck || true
-
- # Set Permissions on install, not upgrade
- if [ -z "$2" ]; then
- chmod 2750 /etc/logcheck/ignore.d.paranoid || true
- chmod 2750 /etc/logcheck/ignore.d.workstation || true
- chmod 2750 /etc/logcheck/ignore.d.server || true
- chmod 2750 /etc/logcheck/cracking.d || true
- chmod 2750 /etc/logcheck/cracking.ignore.d || true
- chmod 2750 /etc/logcheck/violations.d || true
- chmod 2750 /etc/logcheck/violations.ignore.d || true
- chmod -R g+rX /etc/logcheck || true
- fi
- chown -R logcheck:logcheck /var/lib/logcheck || true
- chmod 0770 /var/lib/logcheck || true
-
- ;;
-
- abort-upgrade|abort-remove|abort-deconfigure)
-
- ;;
-
- *)
- echo "postinst called with unknown argument \`$1'" >&2
- exit 1
- ;;
+ *)
+ echo "postinst called with unknown argument \`$1'" >&2
+ exit 1
+ ;;
esac
# dh_installdeb will replace this with shell code automatically
--
1.7.5.4
>From 81be7bd91f122c0e4f0e17d00b141dbcded9496d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Minier?= <l...@debian.org>
Date: Mon, 17 Oct 2011 09:33:35 +0200
Subject: [PATCH 4/4] Merge two tests into a single lt-nl comparison
---
debian/logcheck-database.postinst | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/debian/logcheck-database.postinst b/debian/logcheck-database.postinst
index c8f5337..a9d1a6c 100644
--- a/debian/logcheck-database.postinst
+++ b/debian/logcheck-database.postinst
@@ -31,7 +31,7 @@ confdir="/etc/logcheck"
case "$1" in
configure)
# Remove old sarge mv logcheck-data configfiles if unchanged
- if [ -n "$2" ] && dpkg --compare-versions "$2" lt "1.2.48"; then
+ if dpkg --compare-versions "$2" lt-nl "1.2.48"; then
proftpd_sum=$(sha1sum '/etc/logcheck/ignore.d.paranoid/proftpd' 2>/dev/null \
| awk '{print $1}')
imap_sum=$(sha1sum '/etc/logcheck/ignore.d.paranoid/imap' 2>/dev/null \
--
1.7.5.4
--- End Message ---
--- Begin Message ---
Source: logcheck
Source-Version: 1.3.16
We believe that the bug you reported is fixed in the latest version of
logcheck, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 645...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Hannes von Haugwitz <han...@vonhaugwitz.com> (supplier of updated logcheck
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 26 Jan 2014 17:43:32 +0100
Source: logcheck
Binary: logcheck logcheck-database logtail
Architecture: source all
Version: 1.3.16
Distribution: unstable
Urgency: low
Maintainer: Debian logcheck Team <logcheck-devel@lists.alioth.debian.org>
Changed-By: Hannes von Haugwitz <han...@vonhaugwitz.com>
Description:
logcheck - mails anomalies in the system logfiles to the administrator
logcheck-database - database of system log rules for the use of log checkers
logtail - Print log file lines that have not been read (deprecated)
Closes: 645588 653444 706085 717247 722312
Changes:
logcheck (1.3.16) unstable; urgency=low
.
* ignore.d.server/ssh:
- updated "subsystem request for sftp" rule (closes: #706085)
* debian/control:
- removed obsolete DM-Upload-Allowed field
- build-depend on debhelper (>= 9)
- bumped to Standards-Version 3.9.5 (no changes necessary)
* ignore.d.server/smartd:
- allow additional '[SAT]' field after controller pattern
(closes: #653444)
* ignore.d.server/exim4:
- removed 'gluck.debian.org' specific rule (closes: #722312)
* debian/logcheck-database.postinst, debian/logcheck.postinst:
- applied patches by Loïc Minier (closes: #645588):
- add logcheck alias on install not on upgrade
- use [ -z ... ] rather than [ ! -n ... ]
- fix indentation and whitespaces in postinsts
- merge two tests into a single lt-nl comparison
* ignore.d.server/cron-apt:
- allow '-o quiet=1' in dist-upgrade rule (closes: #717247)
* debian/logcheck-database.maintscript: added
debian/logcheck-database.preinst: removed
- use dpkg-maintscript-helper to remove obsolete config files
- dropped handling of config files removed before squeeze release
* ignore.d.server/puppetd: removed
- rules are part of puppet-common package
Checksums-Sha1:
67fd6f01c426ca62c2d132da32916cdd298f319d 1828 logcheck_1.3.16.dsc
27892a6abf3822d285efbb26f935d80762134679 131832 logcheck_1.3.16.tar.xz
dcb358c06b51a54aa8a2b896a3fa1beee6b875ba 75992 logcheck_1.3.16_all.deb
aa6c1d5714732236dfd8ad3988a9a7248b54dd16 111388
logcheck-database_1.3.16_all.deb
e93b57bbc066224c73191b223c55d0fad330c047 61052 logtail_1.3.16_all.deb
Checksums-Sha256:
ed6f07c5e86b2beb8ca3cec7c3ebfe40d3539697d639035dad452bb1df08ab2a 1828
logcheck_1.3.16.dsc
3eea6f4d25b5cba59d30b8edd35e392389b8e4966d0aceac11c220e98426b8e6 131832
logcheck_1.3.16.tar.xz
07be9d11d47e879a36150a3db0203e3b72d921c4709a695c86433bbb86e794a6 75992
logcheck_1.3.16_all.deb
c9f9b520048cbf447298d90832857a18301a86e74884f6dfcb2c9ec39b7717f6 111388
logcheck-database_1.3.16_all.deb
2d6ab389f67cf399332a04e525c52d623fb3e9f4fe1584259f65ee9e7b43991d 61052
logtail_1.3.16_all.deb
Files:
f816bb3f5f3d8595da2a5da2e6e25a19 1828 admin optional logcheck_1.3.16.dsc
958f397c16e174774bc5bfebe7c949c6 131832 admin optional logcheck_1.3.16.tar.xz
8ceb98af12efbdf9a0057965d0b68705 75992 admin optional logcheck_1.3.16_all.deb
7447f5ee65101cd715005ed41d798ea1 111388 admin optional
logcheck-database_1.3.16_all.deb
94203dfa6137e213c7a99d430792e56d 61052 admin optional logtail_1.3.16_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
iQGcBAEBCAAGBQJS5UloAAoJEBjuhjhgIu9X3J0MAJkDgVh256SLl53xEvucFbEp
E7rcl9JXZbpAJZd/if9JT24sIYaptAO58eQyb/9nJJGUmdtDMMCw/3FDfdQqRRSh
6vnpWiq27DTLCZSQm5DXBJrXN09nxLRWqSGJTj/ycodWkCoyhHGaalc0B9v5072g
Nme0NiNSKG5pkptZ109BvMmhUM7W1PmGeMGZG/ilF2qtSBShFIh74IOvBM4A0+jU
oRinO6qbIe++1wRgywFKtijV9U2YMMSZ6T3FCFI64rawK1ySwD5xnHBk5O7HDtjf
3IvtgWLyo5Ef5QCxWiK6bhJopyl0WxxiEYx2tWqheXJysE4tdj7dNBcp0dM1ApXO
nZHG4sqkDDnDeis3ylGvmkihcAhSl45DP3oaiFSOzKWJVMVJAbjudrGYQz50GJnD
Uk63rzPJK0aUSwRZ8BpKuVdeCjWxizHuei4WAhTQEKR5krNWU+/Ih+VXhlSFH5Na
IDZkOwa/cZaCAiTKsN5KCyfJ3A1BgY6Vw6IFOTWLkA==
=AC1q
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
Logcheck-devel mailing list
Logcheck-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/logcheck-devel
